src: only call .ReThrow() if not terminating #26130
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
jasnell
approved these changes
Feb 15, 2019
|
Resume CI: https://ci.nodejs.org/job/node-test-pull-request/20807/ (:heavy_check_mark:) |
Otherwise, it looks like a `null` exception is being thrown.
addaleax
force-pushed
the
worker-vm-module-rethrow
branch
from
40bf4c3
to
2ad7f95
Compare
|
Rebased, new CI: https://ci.nodejs.org/job/node-test-pull-request/20891/ |
danbev
approved these changes
Feb 20, 2019
|
Landed in 7b19893. |
danbev
pushed a commit
that referenced
this pull request
Feb 20, 2019
Otherwise, it looks like a `null` exception is being thrown. PR-URL: #26130 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
addaleax
added a commit
that referenced
this pull request
Feb 21, 2019
Otherwise, it looks like a `null` exception is being thrown. PR-URL: #26130 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Merged
rvagg
pushed a commit
that referenced
this pull request
Feb 28, 2019
Otherwise, it looks like a `null` exception is being thrown. PR-URL: #26130 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise, it looks like a
nullexception is being thrown.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes